ocket8888 commented on code in PR #7806:
URL: https://github.com/apache/trafficcontrol/pull/7806#discussion_r1327687910
##########
traffic_ops/testing/api/v5/cdn_federations_test.go:
##########
@@ -220,10 +219,9 @@ func validateCDNFederationCNameSort() utils.CkReqFunc {
return func(t *testing.T, _ toclientlib.ReqInf, resp interface{},
alerts tc.Alerts, _ error) {
assert.RequireNotNil(t, resp, "Expected CDN Federation response
to not be nil.")
var federationCNames []string
- CDNFederationResp := resp.([]tc.CDNFederation)
- for _, CDNFederation := range CDNFederationResp {
- assert.RequireNotNil(t, CDNFederation.CName, "Expected
CDN Federation CName to not be nil.")
Review Comment:
Because those cannot be nil, so the check is useless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
