ocket8888 commented on code in PR #7806: URL: https://github.com/apache/trafficcontrol/pull/7806#discussion_r1329257597
########## traffic_ops/traffic_ops_golang/cdnfederation/insert.sql: ########## @@ -0,0 +1,12 @@ +INSERT INTO federation ( Review Comment: I mean, I also thought it would be easier for a reviewer to read them in their own files. I don't think putting more lines into the cdnfederations.go file is going to make the changes to it look any smaller, but if you want these to be inline string constants I can do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
