zrhoffman commented on code in PR #7841:
URL: https://github.com/apache/trafficcontrol/pull/7841#discussion_r1366474549
##########
traffic_ops/build/traffic_ops.spec:
##########
@@ -38,7 +38,7 @@ Requires: openssl-devel, perl, perl-core,
perl-DBD-Pg, perl-DBI, perl-Di
Requires: libidn-devel, libcurl-devel, libcap
Requires: postgresql13 >= 13.2
Requires: perl-JSON, perl-libwww-perl, perl-Test-CPAN-Meta,
perl-WWW-Curl, perl-TermReadKey, perl-Crypt-ScryptKDF
-Requires: python(abi)
+Requires: python(abi), python3
Review Comment:
Since the `python3` package is only required on CentOS 7, instead of adding
`python3` to this line, adding this additional line would work (and avoid an
additional dependency on Rocky Linux 8 and up):
```spec
{?el7:Requires: python3}
```
##########
.github/workflows/postinstall.tests.yml:
##########
@@ -31,8 +31,7 @@ on:
types: [ opened, reopened, ready_for_review, synchronize ]
env:
- PYTHON3_VERSION: '3.6'
- PYTHON2_VERSION: '2.7'
+ PYTHON3_VERSION: '3.8'
Review Comment:
1. Python 3.8 is not available on CentOS 7, which the project still
supports. Just Python 3.6
2. Rocky Linux's platform-python is Python 3.6:
```shell
docker run --rm rockylinux:8 /usr/libexec/platform-python --version
```
So the minimum supported version still needs to be Python 3.6.
##########
traffic_ops/install/bin/postinstall:
##########
@@ -26,9 +26,9 @@ for arg in "$@"; do
done
PATH+=:/usr/libexec/
-python_bin="$(command -v {python,platform-python}{3{{.,}{9,8,7,6},},2{7,.7,},}
| head -n1)"
+python_bin="$(command -v {python,platform-python}{3{{.,}{12,11,10,9,8,7,6},},}
| head -n1)"
Review Comment:
`{12,11,10,9,8,7,6}` can be `{12..6}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
