zrhoffman commented on code in PR #7841:
URL: https://github.com/apache/trafficcontrol/pull/7841#discussion_r1449156909


##########
traffic_ops/build/traffic_ops.spec:
##########
@@ -38,7 +38,7 @@ Requires:         openssl-devel, perl, perl-core, 
perl-DBD-Pg, perl-DBI, perl-Di
 Requires:         libidn-devel, libcurl-devel, libcap
 Requires:         postgresql13 >= 13.2
 Requires:         perl-JSON, perl-libwww-perl, perl-Test-CPAN-Meta, 
perl-WWW-Curl, perl-TermReadKey, perl-Crypt-ScryptKDF
-Requires:         python(abi)
+Requires:         python(abi), python3

Review Comment:
   Rocky 8 comes with Python 3.6 at `/usr/libexec/platform-python3.6` (provided 
by the `platform-python` package), which the postinstall script can use:
   
   
https://github.com/apache/trafficcontrol/blob/ca5955ca3309534e8656430522745f8d2e39fd99/traffic_ops/install/bin/postinstall#L28-L29
   
   So if you want, you could add Python 3 as a dependency in CentOS 7 only like
   
   ```spec
   {?el7:Requires: python3}
   ```
   
   (similar to
   
https://github.com/apache/trafficcontrol/blob/814de6e540048f401e23f1be7a55296dea7efd22/cache-config/testing/docker/trafficserver/trafficserver-9.spec#L47-L48
   )
   
   but adding python3 as a Traffic Ops dependency doesn't really hurt anything 
either way



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to