ocket8888 commented on code in PR #7846:
URL: https://github.com/apache/trafficcontrol/pull/7846#discussion_r1379097325
##########
traffic_portal/app/src/common/modules/form/physLocation/FormPhysLocationController.js:
##########
@@ -42,7 +42,7 @@ var FormPhysLocationController = function(physLocation,
$scope, $location, formU
{ name: 'shortName', type: 'text', required: true, maxLength: 100 },
{ name: 'address', type: 'text', required: true, maxLength: 128 },
{ name: 'city', type: 'text', required: true, maxLength: 128 },
- { name: 'state', type: 'text', required: true, maxLength: 2 },
+ { name: 'state', type: 'text', required: true, maxLength: 4 },
Review Comment:
This should match the limitations set by the API - and currently there is no
max length in the API. You might arbitrarily choose something huge like 255 but
5+ characters is actually totally valid and our front-end ought to model that
more accurately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
