ocket8888 commented on code in PR #7846:
URL: https://github.com/apache/trafficcontrol/pull/7846#discussion_r1388802581
##########
traffic_portal/app/src/common/modules/form/physLocation/FormPhysLocationController.js:
##########
@@ -42,7 +42,7 @@ var FormPhysLocationController = function(physLocation,
$scope, $location, formU
{ name: 'shortName', type: 'text', required: true, maxLength: 100 },
{ name: 'address', type: 'text', required: true, maxLength: 128 },
{ name: 'city', type: 'text', required: true, maxLength: 128 },
- { name: 'state', type: 'text', required: true, maxLength: 2 },
+ { name: 'state', type: 'text', required: true, maxLength: 4 },
Review Comment:
You could do that, but that would be a breaking API change which would
necessitate an APIv6, deprecation strategy, and a plan on how to eventually
migrate old data to the new, more restrictive format.
It'd be a lot less work to just eliminate the requirement altogether in the
UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
