ocket8888 commented on code in PR #7933: URL: https://github.com/apache/trafficcontrol/pull/7933#discussion_r1480831247
########## experimental/traffic-portal/build/traffic_portal_v2.spec: ########## @@ -25,7 +25,7 @@ License: Apache License, Version 2.0 URL: https://github.com/apache/trafficcontrol/ Source: %{_sourcedir}/traffic-portal-%{traffic_control_version}.tgz AutoReqProv: no -Requires: nodejs >= 2:16.14.0 +Requires: nodejs >= 2:18.0.0 Review Comment: @zrhoffman can we do this? Sorry, I should really just look it up on my own ########## experimental/traffic-portal/.eslintrc.json: ########## @@ -349,7 +349,7 @@ ], "require": { "ClassDeclaration": true, - "MethodDefinition": true + "MethodDefinition": false Review Comment: The rules shouldn't need to change to fix this. Are there unreported failures currently committed? In that case, just let the linter fail and we can fix them in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
