ntheanh201 commented on code in PR #7933:
URL: https://github.com/apache/trafficcontrol/pull/7933#discussion_r1480842575


##########
experimental/traffic-portal/.eslintrc.json:
##########
@@ -349,7 +349,7 @@
                                                ],
                                                "require": {
                                                        "ClassDeclaration": 
true,
-                                                       "MethodDefinition": true
+                                                       "MethodDefinition": 
false

Review Comment:
   > The rules shouldn't need to change to fix this. Are there unreported 
failures currently committed? In that case, just let the linter fail and we can 
fix them in a follow-up.
   
   currently, when you run lint, then the linter will not show the methods that 
don't have jsdoc. I will revert this change, and you'll see the lint fail



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to