ntheanh201 commented on code in PR #7981:
URL: https://github.com/apache/trafficcontrol/pull/7981#discussion_r1569168875
##########
pkg:
##########
@@ -247,7 +262,7 @@ while (( "$#" )); do
# where <service> is the name of the specific service to be
chained. The file may be a symlink to another
# compose file, in which case the symlink will be followed
before it is processed.
if [ -e "$COMPOSE_FILE.$1" ] ; then
- $SELF -f $(realpath -e "$COMPOSE_FILE.$1") $([
"$verbose" == 0 ] || echo "-v") $([ "$quiet" == 0 ] || echo "-q") $([ "$debug"
== 0 ] || echo "-d") $([ "$build" == 0 ] || echo "-b") $("${COMPOSECMD[@]}" -f
$(realpath -e "$COMPOSE_FILE.$1") config --services)
+ $SELF -f $(realpath "$COMPOSE_FILE.$1") $([ "$verbose"
== 0 ] || echo "-v") $([ "$quiet" == 0 ] || echo "-q") $([ "$debug" == 0 ] ||
echo "-d") $([ "$build" == 0 ] || echo "-b") $("${COMPOSECMD[@]}" -f $(realpath
"$COMPOSE_FILE.$1") config --services)
Review Comment:
<img width="319" alt="image"
src="https://github.com/apache/trafficcontrol/assets/29043139/2d2b69f8-b787-4147-ad2f-770902a152a4";>
I see if you still use `-e` argument with realpath, it won't work
##########
pkg:
##########
@@ -247,7 +262,7 @@ while (( "$#" )); do
# where <service> is the name of the specific service to be
chained. The file may be a symlink to another
# compose file, in which case the symlink will be followed
before it is processed.
if [ -e "$COMPOSE_FILE.$1" ] ; then
- $SELF -f $(realpath -e "$COMPOSE_FILE.$1") $([
"$verbose" == 0 ] || echo "-v") $([ "$quiet" == 0 ] || echo "-q") $([ "$debug"
== 0 ] || echo "-d") $([ "$build" == 0 ] || echo "-b") $("${COMPOSECMD[@]}" -f
$(realpath -e "$COMPOSE_FILE.$1") config --services)
+ $SELF -f $(realpath "$COMPOSE_FILE.$1") $([ "$verbose"
== 0 ] || echo "-v") $([ "$quiet" == 0 ] || echo "-q") $([ "$debug" == 0 ] ||
echo "-d") $([ "$build" == 0 ] || echo "-b") $("${COMPOSECMD[@]}" -f $(realpath
"$COMPOSE_FILE.$1") config --services)
Review Comment:
<img width="319" alt="image"
src="https://github.com/apache/trafficcontrol/assets/29043139/2d2b69f8-b787-4147-ad2f-770902a152a4";>
I see if you still use `-e` argument with realpath, it won't work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
