zrhoffman commented on code in PR #7981:
URL: https://github.com/apache/trafficcontrol/pull/7981#discussion_r1622297625


##########
build/functions.sh:
##########
@@ -13,16 +13,44 @@
 #
 # shellcheck shell=ash
 
-if ! type -p realpath; then
-       # by default, macOS does not have realpath
-       realpath() {
-               ls "$(
-                       cd "$(dirname "$0")"
-                       pwd -P # -P resolves symlinks
-               )/$(basename "$0")"
-       }
-       export -f realpath
-fi;
+# macOS's version of realpath does not resolve symlinks, so we add a function
+# for it.
+get_realpath() {

Review Comment:
   Fixed for macOS and BSDs by checking for  `grealpath` as well in e298e4a4b.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to