zrhoffman commented on code in PR #8009:
URL: https://github.com/apache/trafficcontrol/pull/8009#discussion_r1608540249
##########
.github/workflows/tpv2.yml:
##########
@@ -280,6 +280,22 @@ jobs:
uses: actions/checkout@master
with:
fetch-depth: 5
+ - name: Cache node modules
+ id: restore-npm-cache
+ uses: actions/cache@v3
+ with:
+ path: ./experimental/traffic-portal/node_modules
+ key: ${{ runner.os }}-node-${{
hashFiles('./experimental/traffic-portal/package-lock.json') }}
+ restore-keys: |
+ ${{ runner.os }}-node-
+ - name: Node 20
+ uses: actions/setup-node@v3
+ with:
+ node-version: 20.x
+ - name: Checkout
+ uses: actions/checkout@v2
+ with:
+ fetch-depth: 5
Review Comment:
The checkout action is already used above. This should be removed.
##########
.github/workflows/tpv2.yml:
##########
@@ -280,6 +280,22 @@ jobs:
uses: actions/checkout@master
with:
fetch-depth: 5
+ - name: Cache node modules
+ id: restore-npm-cache
+ uses: actions/cache@v3
+ with:
+ path: ./experimental/traffic-portal/node_modules
+ key: ${{ runner.os }}-node-${{
hashFiles('./experimental/traffic-portal/package-lock.json') }}
+ restore-keys: |
+ ${{ runner.os }}-node-
Review Comment:
The *Cache node modules* step already exists below. This should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
