zrhoffman commented on code in PR #8009:
URL: https://github.com/apache/trafficcontrol/pull/8009#discussion_r1608553709
##########
.github/workflows/tpv2.yml:
##########
@@ -280,6 +280,22 @@ jobs:
uses: actions/checkout@master
with:
fetch-depth: 5
+ - name: Cache node modules
+ id: restore-npm-cache
+ uses: actions/cache@v3
+ with:
+ path: ./experimental/traffic-portal/node_modules
+ key: ${{ runner.os }}-node-${{
hashFiles('./experimental/traffic-portal/package-lock.json') }}
+ restore-keys: |
+ ${{ runner.os }}-node-
+ - name: Node 20
+ uses: actions/setup-node@v3
+ with:
+ node-version: 20.x
+ - name: Checkout
+ uses: actions/checkout@v2
+ with:
+ fetch-depth: 5
Review Comment:
`@master` refers to https://github.com/actions/checkout/commits/master and
`@v2` refers to https://github.com/actions/checkout/commits/v2.
It looks like the actions/checkout `master` branch has not been updated in 4
years, since they changed the default branch to `main`, so that should be
updated to either `v2` or `main`.
##########
.github/workflows/tpv2.yml:
##########
@@ -280,6 +280,22 @@ jobs:
uses: actions/checkout@master
with:
fetch-depth: 5
+ - name: Cache node modules
+ id: restore-npm-cache
+ uses: actions/cache@v3
+ with:
+ path: ./experimental/traffic-portal/node_modules
+ key: ${{ runner.os }}-node-${{
hashFiles('./experimental/traffic-portal/package-lock.json') }}
+ restore-keys: |
+ ${{ runner.os }}-node-
Review Comment:
No, `restore-keys` is optional. See
https://github.com/actions/cache?tab=readme-ov-file#inputs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
