Github user dneuman64 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/167#discussion_r95588778
--- Diff: traffic_stats/influxdb_tools/sync/sync_test.go ---
@@ -0,0 +1,230 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+package main
+
+import (
+ "encoding/json"
+ "fmt"
+ "testing"
+
+ influx "github.com/influxdata/influxdb/client/v2"
+ "github.com/influxdata/influxdb/models"
+ . "github.com/smartystreets/goconvey/convey"
--- End diff --
IMO we should just use the standard testing package for this code. This
code is really more a set of loosely related scripts than a "program" which is
why there wasn't any unit tests to begin with. Additionally, the logic in this
code isn't changing all that often so encouraging people to write their own
tests is not a concern to me. If we want to explore the idea of using a test
framework for our unit tests I think the Traffic Ops client code or goTM
(Traffic_monitor/experimental) are better candidates.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
