[
https://issues.apache.org/jira/browse/TC-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894540#comment-15894540
]
ASF GitHub Bot commented on TC-72:
----------------------------------
Github user rob05c commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/327
@dangogh @alficles Yes, traffic_monitor and traffic_monitor_golang should
never both be built. One is replacing the other. The plan is to rename the
`traffic_monitor_golang` directory to `traffic_monitor` and remove the old
`traffic_monitor` once it's stable. Until we change the name and officially
"replace" the old one, Docker Compose shouldn't build
`traffic_monitor_golang`.
+1 on commenting it. Leaving in there and commented will make it easier for
those of us testing the new version.
On Fri, Mar 3, 2017 at 8:01 AM, alficles <[email protected]> wrote:
> This is a marked improvement, but it introduces a new issue: make clean.
> Since the build is happening directly in the local directories, all the
> temporary files will be left around. There's two ways around this, either
> copy the entire build folder into a new directory inside the container and
> just copy the final binaries out, or introduce a cleaning functionality
> that will remove the intermediate files.
>
> I like the second option better, but the first is significantly easier, I
> think.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/incubator-trafficcontrol/pull/327#issuecomment-283976269>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AE4GTdGNvkayhST2qZAkDrL6ZCbQRVukks5riCtJgaJpZM4MQARS>
> .
>
> docker build to use local directory rather than cloning from github
> -------------------------------------------------------------------
>
> Key: TC-72
> URL: https://issues.apache.org/jira/browse/TC-72
> Project: Traffic Control
> Issue Type: Improvement
> Components: all
> Affects Versions: 1.9.0
> Reporter: Dan Kirkwood
> Assignee: Dan Kirkwood
> Priority: Minor
> Fix For: 1.9.0
>
>
> docker build of trafficcontrol requires connecting to github. Should be
> able to use the local directory instead.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
