[
https://issues.apache.org/jira/browse/TC-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15903523#comment-15903523
]
ASF GitHub Bot commented on TC-72:
----------------------------------
Github user alficles commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/327
Ok. I've tested this. It correctly produces binaries in the `dist`
directory, without polluting your environment. For anyone else testing, make
sure your docker is on the absolute latest. There's a bug in the penultimate
build that is exercised by the `cp -a` in the new script.
I'm +1 on this merge, with a few comments:
- The `BUILD.md` file doesn't list the new tarball build option. This is a
particularly useful option.
- The `BUILD.md` identifies the wrong target folder.
- The build command is really quite long. This is just an opinion, but we
may want to add a tiny script that encodes the commands prescribed by
`BUILD.md`.
> docker build to use local directory rather than cloning from github
> -------------------------------------------------------------------
>
> Key: TC-72
> URL: https://issues.apache.org/jira/browse/TC-72
> Project: Traffic Control
> Issue Type: Improvement
> Components: all
> Affects Versions: 1.9.0
> Reporter: Dan Kirkwood
> Assignee: Dan Kirkwood
> Priority: Minor
> Fix For: 2.0.0
>
>
> docker build of trafficcontrol requires connecting to github. Should be
> able to use the local directory instead.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
