[
https://issues.apache.org/jira/browse/TC-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956323#comment-15956323
]
ASF GitHub Bot commented on TC-119:
-----------------------------------
GitHub user rob05c opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/428
Deprecate TO client ResumeSession, remove juju dependency
Changes the TO client ResumeSession to always return nil and an error
as if the persisted cookie had expired, and adds a Deprecated comment
indicating it will be removed in the next version.
This allows us to remove the juju persistent cookie dependency, which
has an incompatible license.
It also seems reasonable to deprecate and remove ResumeSession, as
Traffic Control itself doesn't use it, and any users would need logic
to handle expired cookies and do an ordinary Login anyway, which is
not an expensive operation.
TC-119 #close
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rob05c/incubator-trafficcontrol
to-deprecateresumesession
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/428.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #428
----
commit 5736ec732047a0abd4fc5a8b7eadf93f855d2aa3
Author: Robert Butts <robert.o.bu...@gmail.com>
Date: 2017-04-05T04:28:15Z
Deprecate TO client ResumeSession, remove juju dep
Changes the TO client ResumeSession to always return nil and an error
as if the persisted cookie had expired, and adds a Deprecated comment
indicating it will be removed in the next version.
This allows us to remove the juju persistent cookie dependency, which
has an incompatible license.
It also seems reasonable to deprecate and remove ResumeSession, as
Traffic Control itself doesn't use it, and any users would need logic
to handle expired cookies and do an ordinary Login anyway, which is
not an expensive operation.
TC-119 #close
----
> traffic_ops/client dependency license issue
> -------------------------------------------
>
> Key: TC-119
> URL: https://issues.apache.org/jira/browse/TC-119
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops Client
> Affects Versions: 2.0.0
> Reporter: Dan Kirkwood
> Assignee: Robert Butts
> Fix For: 2.0.0
>
>
> `traffic_ops/client` uses this library to store cookies:
> https://github.com/juju/persistent-cookiejar
> This library has an Apache-compatible license, but it has a dependency with
> an incompatible LGPL license: gopkg.in/retry.v1. It is included in our
> vendored source here: `traffic_stats/vendor/gopkg.in/retry.v1`
> We need to deal with that somehow...
> NOTE: 1.8.x does not include this library, since persistent-cookiejar was
> added after the 1.8.x branch was created.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
