[ 
https://issues.apache.org/jira/browse/TC-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967061#comment-15967061
 ] 

ASF GitHub Bot commented on TC-231:
-----------------------------------

GitHub user mitchell852 opened a pull request:

    https://github.com/apache/incubator-trafficcontrol/pull/464

    [TC-231] - adds a query param (exclude) that can prevent the fetching of 
the ver…

    …y expensive exampleURLs property. if not used (?exclude=exampleURLs), the 
api behaves as usual.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mitchell852/incubator-trafficcontrol TC-231

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafficcontrol/pull/464.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #464
    
----
commit 36b432f9dcfd07477280550ace6a4d10f0c877ec
Author: Jeremy Mitchell <[email protected]>
Date:   2017-04-13T03:29:26Z

    adds a query param (exclude) that can prevent the fetching of the very 
expensive exampleURLs property. if not used (?exclude=exampleURLs), the api 
behaves as usual.

----


> GET /api/deliveryservices is very slow when resultset gets large
> ----------------------------------------------------------------
>
>                 Key: TC-231
>                 URL: https://issues.apache.org/jira/browse/TC-231
>             Project: Traffic Control
>          Issue Type: Improvement
>          Components: Traffic Ops API
>    Affects Versions: 2.0.0, 2.1.0
>            Reporter: Jeremy Mitchell
>            Assignee: Jeremy Mitchell
>
> With the change from mysql to postgres and when postgres is hosted in a 
> remote environment (seperate from TO), /api/version/deliveryservices is very 
> slow as the number of delivery services grows. This is because the code loops 
> thru the result set and builds "example urls" for each deliveryservice. This 
> operation is expensive.
> Rather than breaking the API and leaving out exampleURLs by default from the 
> response, I suggest we allow the API consumer to pass thru a query parameter 
> such as:
> ?exclude=exampleURLs



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to