[
https://issues.apache.org/jira/browse/TC-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971342#comment-15971342
]
ASF GitHub Bot commented on TC-231:
-----------------------------------
GitHub user mitchell852 opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/474
[TC-231] - optimizes api/version/deliveryservices and
api/version/deliveryservic…
…es/:id by joining tables and avoiding n+1 queries. also fixes a couple of
tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mitchell852/incubator-trafficcontrol
tc-231-exampleurls
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/474.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #474
----
commit 85bdb2624cb645d916a1f95b955465eed49a5572
Author: Jeremy Mitchell <[email protected]>
Date: 2017-04-17T17:03:52Z
optimizes api/version/deliveryservices and api/version/deliveryservices/:id
by joining tables and avoiding n+1 queries. also fixes a couple of tests.
----
> GET /api/deliveryservices is very slow when resultset gets large
> ----------------------------------------------------------------
>
> Key: TC-231
> URL: https://issues.apache.org/jira/browse/TC-231
> Project: Traffic Control
> Issue Type: Improvement
> Components: Traffic Ops API
> Affects Versions: 2.0.0, 2.1.0
> Reporter: Jeremy Mitchell
> Assignee: Jeremy Mitchell
>
> With the change from mysql to postgres and when postgres is hosted in a
> remote environment (seperate from TO), /api/version/deliveryservices is very
> slow as the number of delivery services grows. This is because the code loops
> thru the result set and builds "example urls" for each deliveryservice. This
> operation is expensive.
> Rather than breaking the API and leaving out exampleURLs by default from the
> response, I suggest we allow the API consumer to pass thru a query parameter
> such as:
> ?exclude=exampleURLs
> UPDATE: actually, a better solution is to just optimize the underlying
> queries. This is usually solved by simply joining tables in the query. 1
> complex query involving joins is better than 500 simple queries.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
