Github user mitchell852 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/742#discussion_r129072174
--- Diff: traffic_ops/app/lib/API/Deliveryservice.pm ---
@@ -292,7 +308,10 @@ sub update {
}
#setting tenant_id to undef if tenant is not set.
- my $tenant_id = exists($params->{tenantId}) ? $params->{tenantId} :
undef;
+ my $tenant_id = exists($params->{tenantId}) ? $params->{tenantId} :
undef;
--- End diff --
does this allow me to set the ds.tenant to null thru the api? If so, is
that something that we want to allow? By allowing me to set a ds.tenant = null
i can now see the ds regardless of my user.tenant value. seems like a security
loophole.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
