Github user nir-sopher commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafficcontrol/pull/742#discussion_r129162314
  
    --- Diff: traffic_ops/app/lib/API/Deliveryservice.pm ---
    @@ -153,21 +158,26 @@ sub show {
        my $current_user = $self->current_user()->{username};
        my @data;
     
    -   if ( !&is_privileged($self) ) {
    +   my $tenant_utils = Utils::Tenant->new($self);
    +   my $tenants_data = $tenant_utils->create_tenants_data_from_db();
    +
    +   if ( !&is_privileged($self) and 
!$tenant_utils->ignore_ds_users_table()) {
     
                # check to see if deliveryservice is assigned to user, if not 
return forbidden
    --- End diff --
    
    I assume you refer to the code in the lines below the added code.
    Done. 
    Do you know by any chance if this functionality is covered by UT?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to