[
https://issues.apache.org/jira/browse/TC-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137968#comment-16137968
]
ASF GitHub Bot commented on TC-547:
-----------------------------------
GitHub user zhilhuan opened a pull request:
https://github.com/apache/incubator-trafficcontrol/pull/855
[TC-547] Fix regression issues caused by TC-187
Fix regression issues caused by TC-187:
1. revert: replace xml_id with ds_<ds-id> as riak key for ssl certificate
2. revert: decode base64 for ssl csr, crt, key in restful api
Add missing code for update ssl keystore when hostname changes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhilhuan/incubator-trafficcontrol TC-547
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafficcontrol/pull/855.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #855
----
commit 8dd685f4ee99c17f212839bc7d61e9b7553d6e67
Author: Zhilin Huang <[email protected]>
Date: 2017-08-23T03:03:03Z
Fix regression issues caused by TC-187:
1. revert: replace xml_id with ds_<ds-id> as riak key for ssl certificate
2. revert: decode base64 for ssl csr, crt, key in restful api
Add missing code for update ssl keystore when hostname changes
----
> Fix regression issues caused by TC-187
> --------------------------------------
>
> Key: TC-547
> URL: https://issues.apache.org/jira/browse/TC-547
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops
> Affects Versions: 3.0.0
> Reporter: Zhilin Huang
> Assignee: Zhilin Huang
>
> Fix for TC-187 introduced change to use "ds_<ds-id>" instead of xml_id as the
> key to put SSL certificate to riak server.
> This may cause regression issues when doing migration. And as xml_id becomes
> immutable now, this change is not needed anymore.
> Also the change for get ssl certificate in API may cause regression issue.
> Will revert it as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)