[
https://issues.apache.org/jira/browse/TC-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138651#comment-16138651
]
ASF GitHub Bot commented on TC-547:
-----------------------------------
Github user rawlinp commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/855
Looks good to me. Thanks for fixing this!
Note that we'll have to figure out if we want to regenerate the actual
certs too (rather than just the hostname in the riak record), but we'll tackle
that in a new PR once we've discussed what needs to be done about that.
> Fix regression issues caused by TC-187
> --------------------------------------
>
> Key: TC-547
> URL: https://issues.apache.org/jira/browse/TC-547
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops
> Affects Versions: 3.0.0
> Reporter: Zhilin Huang
> Assignee: Zhilin Huang
>
> Fix for TC-187 introduced change to use "ds_<ds-id>" instead of xml_id as the
> key to put SSL certificate to riak server.
> This may cause regression issues when doing migration. And as xml_id becomes
> immutable now, this change is not needed anymore.
> Also the change for get ssl certificate in API may cause regression issue.
> Will revert it as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
