dangogh commented on a change in pull request #1895: Updated /regions to use
the CRUD interface
URL:
https://github.com/apache/incubator-trafficcontrol/pull/1895#discussion_r170091590
##########
File path: traffic_ops/traffic_ops_golang/routes.go
##########
@@ -102,13 +103,16 @@ func Routes(d ServerData) ([]Route, http.Handler, error)
{
//HwInfo
{1.2, http.MethodGet, `hwinfo-wip/?(\.json)?$`,
hwInfoHandler(d.DB), auth.PrivLevelReadOnly, Authenticated, nil},
+ //Regions
+ {1.3, http.MethodGet, `regions/?(\.json)?$`,
api.ReadHandler(region.GetRefType(), d.DB), auth.PrivLevelReadOnly,
Authenticated, nil},
+ {1.3, http.MethodGet, `regions/{id}$`,
api.ReadHandler(region.GetRefType(), d.DB), auth.PrivLevelReadOnly,
Authenticated, nil},
+ {1.3, http.MethodPut, `regions/{id}$`,
api.UpdateHandler(region.GetRefType(), d.DB), auth.PrivLevelOperations,
Authenticated, nil},
+ {1.3, http.MethodPost, `regions/?$`,
api.CreateHandler(region.GetRefType(), d.DB), auth.PrivLevelOperations,
Authenticated, nil},
+ {1.3, http.MethodDelete, `regions/{id}$`,
api.DeleteHandler(region.GetRefType(), d.DB), auth.PrivLevelOperations,
Authenticated, nil},
+
Review comment:
don't we want these to be alphabetized?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services