rawlinp commented on a change in pull request #1908: Changes for Backup Edge 
Cache Group
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/1908#discussion_r171950588
 
 

 ##########
 File path: 
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/loc/NetworkNode.java
 ##########
 @@ -137,18 +157,19 @@ public static NetworkNode generateTree(final JsonNode 
json, final boolean verify
         return null;
     }
 
+
+    @SuppressWarnings({"PMD.CyclomaticComplexity", "PMD.NPathComplexity"})
     private static boolean addNetworkNodesToRoot(final SuperNode root, final 
String loc, final JsonNode locData,
-                                                 final Geolocation 
geolocation, final boolean useDeep) {
+                                                 final Geolocation 
geolocation, final List<String> bkCacheLoc, final boolean useDeep, final 
boolean useClosestOnBackupFailure) {
 
 Review comment:
   `backupCacheGroups` rather than `bkCacheLoc`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to