rawlinp commented on a change in pull request #1908: Changes for Backup Edge Cache Group URL: https://github.com/apache/incubator-trafficcontrol/pull/1908#discussion_r171947182
########## File path: traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/loc/NetworkNode.java ########## @@ -106,15 +108,33 @@ public static NetworkNode generateTree(final JsonNode json, final boolean verify final String loc = czIter.next(); final JsonNode locData = JsonUtils.getJsonNode(coverageZones, loc); final JsonNode coordinates = locData.get("coordinates"); + final JsonNode backupConfigNode = locData.get("backupZones"); Review comment: kind of a nitpick but can we call this variable `backupConfigJson`? All the `Node` stuff is confusing with JsonNode vs NetworkNode. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services