[
https://issues.apache.org/jira/browse/TS-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752217#comment-13752217
]
ASF subversion and git services commented on TS-2162:
-----------------------------------------------------
Commit c7d8e1a5fc5a74aa683051e66974013a22f8d674 in branch refs/heads/master
from [~yunkai]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=c7d8e1a ]
TS-2162: Auto-created collation LogObject would be misused by access log
When collation host receives LogBuffer data from network, it'll create
LogObject according the data's format automatically.
Since the LogFilter of these auto-created LogObjects are empty, they
will be misused by access log generated by collation host itself –
toss_this_entry() will always return false when m_does_conjunction is
set.
This patch introduces a new member variable: m_auto_created in LogObject,
so that we can distinguish this type of LogObject to avoid misusing.
Signed-off-by: Yunkai Zhang <[email protected]>
> Auto-created collation LogObject would be misused by access log
> ---------------------------------------------------------------
>
> Key: TS-2162
> URL: https://issues.apache.org/jira/browse/TS-2162
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
> Reporter: Yunkai Zhang
> Assignee: Yunkai Zhang
> Fix For: 4.1.0
>
> Attachments:
> 0001-TS-2162-Auto-created-collation-LogObject-would-be-mi.patch
>
>
> When collation host receives LogBuffer data from network, it'll create
> LogObject according the data's format.
> Since the LogFilter of these auto-created LogObjects are empty, they will be
> misused by access log generated by collation host itself -- toss_this_entry()
> will always return false when m_does_conjunction is set.
> I have a simple solution to fix this issue: make toss_this_entry() returns
> true when filter list is empty.
> ==NOTE==
> After apply this solution, user should configure at least one LogFilter for
> each LogObject in logs_xml.config, otherwise the LogObject will be tossed
> always. Luckily, that is what most users do. I will update the comment of
> logs_xml.config.default at the same time to reflect this minor change.
> ==Update==
> In order to keep backwards compatibility, I thought a new solution:
> introduces a new member variable: m_auto_created in LogObject, so that we can
> distinguish this type of LogObject to avoid misusing.
> I'll give a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
