[
https://issues.apache.org/jira/browse/TS-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754850#comment-13754850
]
ASF subversion and git services commented on TS-2162:
-----------------------------------------------------
Commit a75ebb6372c7e64c415d6fb29d8d24038ee79525 in branch refs/heads/5.0.x from
[~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=a75ebb6 ]
Merge branch 'master' into 5.0.x
* master: (53 commits)
Moved the two 4.0.1 changes that we respun build for.
Added TS-2163
TS-2163 Remove obsolete WDA and ACC alarms feature
ci: move jenkins jobs to the jenkins subdirectory
ci: toggle --enable-wccp correctly for different platforms
Doc: Add lifecycle hook documentation.
TS-2145: Add metrics for log collation
fixed some spelling mistakes in the api header
TS-2162: Auto-created collation LogObject would be misused by access log
Some indentation and printf cleanup
TS-2161: TSHttpTxnHookAdd memory Leak
TS-2156: Fix stats trap in different type of threads
doc: move cache glossary into the main glossary
TS-2160: Update CHANGES.
TS-2160: Remove ats_is_ip_nonroutable.
TS-2160: Remove use of ats_is_ip_nonroutable and replace with
ats_is_ip_linklocal and ats_is_ip_private.
TS-2160: Add ats_is_ip_private and ats_is_ip_linklocal functions.
TS-2154: Lua plugin asserts traffic_server on startup
ci: make git scm polling less aggresive
ci: flip the 3.4.x branch to 4.0.x
...
> Auto-created collation LogObject would be misused by access log
> ---------------------------------------------------------------
>
> Key: TS-2162
> URL: https://issues.apache.org/jira/browse/TS-2162
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
> Reporter: Yunkai Zhang
> Assignee: Yunkai Zhang
> Fix For: 4.1.0
>
> Attachments:
> 0001-TS-2162-Auto-created-collation-LogObject-would-be-mi.patch
>
>
> When collation host receives LogBuffer data from network, it'll create
> LogObject according the data's format.
> Since the LogFilter of these auto-created LogObjects are empty, they will be
> misused by access log generated by collation host itself -- toss_this_entry()
> will always return false when m_does_conjunction is set.
> I have a simple solution to fix this issue: make toss_this_entry() returns
> true when filter list is empty.
> ==NOTE==
> After apply this solution, user should configure at least one LogFilter for
> each LogObject in logs_xml.config, otherwise the LogObject will be tossed
> always. Luckily, that is what most users do. I will update the comment of
> logs_xml.config.default at the same time to reflect this minor change.
> ==Update==
> In order to keep backwards compatibility, I thought a new solution:
> introduces a new member variable: m_auto_created in LogObject, so that we can
> distinguish this type of LogObject to avoid misusing.
> I'll give a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
