[
https://issues.apache.org/jira/browse/TS-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838165#comment-13838165
]
Leif Hedstrom commented on TS-2401:
-----------------------------------
Looks good, great cleanup!
Couple of thoughts /nit-picks:
In 4c50d676fe29e188f06c197eaa91c80858526bb0, it says:
{code}
if (access(logfile_dir, R_OK | W_OK | X_OK) == -1) {
// Try 'system_root_dir/var/log/trafficserver' directory
fprintf(stderr,"unable to access log directory '%s': %d, %s\n",
logfile_dir, errno, strerror(errno));
fprintf(stderr,"please set 'proxy.config.log.logfile_dir'\n");
_exit(1);
}
{code}
I think the comment is unnecessary / out of place now, since we only "test" the
log-dir from Layout. There's also (at least) two places where we deal with
proxy.config.log.logfile_dir vs the Layout default, maybe it'd be prudent to
have one function /method somewhere to get the system logdir ? Kinda how you
added RecConfigReadRuntimeDir() in a subsequent patch.
In 7d2b07c30e74945f8da9845039c116002f0f0fc4, does that disable the possibility
of STANDALONE_IOCORE? The comments from the deleted code hints at that.
> use Layout instead of system_config_directory
> ---------------------------------------------
>
> Key: TS-2401
> URL: https://issues.apache.org/jira/browse/TS-2401
> Project: Traffic Server
> Issue Type: Bug
> Components: Cleanup, Core
> Reporter: James Peach
> Assignee: James Peach
> Fix For: 4.2.0
>
> Attachments: TS-2401.diff
>
>
> The global {{char system_config_directory[]}} makes it hard to link
> additional programs. We should be able to be replace all usages of this with
> the Layout API.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
