[
https://issues.apache.org/jira/browse/TS-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13869961#comment-13869961
]
Kit Chan commented on TS-2488:
------------------------------
I have added additional changes to try to make it work. Yu Qing, please make a
look at the latest attachment.
Here are some notes for that
1) I have removed the check for '/' because it wasn't mentioned what it is for.
2) I have commented out the line to "skip the space char" because this will
cause test 42 in parser_test to fail
3) I have added code to fail when there is tag match without proper space
character match.
4) I have added code to declare a partial match there is tag match but don't
have enough character to do space character match.
5) I have split the processing case of VARS and HTML_COMMENTS so I can properly
get data for the HTML_COMMENT node. That's needed for test 37-39 in parser_test
6) At the end we only change test case for test 9 and test 18 for parser test
to accommodate the new logic related to space character match.
Yu Qing, it will be great if you can review them before I commit.
> any of the space chars can follow the esi starting tags
> -------------------------------------------------------
>
> Key: TS-2488
> URL: https://issues.apache.org/jira/browse/TS-2488
> Project: Traffic Server
> Issue Type: Improvement
> Components: Plugins
> Reporter: Yu Qing
> Assignee: Kit Chan
> Attachments:
> 0001-TS-2488-any-space-char-can-follow-the-esi-starting-t.patch, 2488.txt
>
>
> only the space char ' ' can follow the esi starting tags such as
> "<esi:include", "<!--esi" now, we should allow any space char after these
> tags. the space chars include: ' ', '\t', '\r' and '\n'.
> for example, following common usage:
> <!--esi
> esi bala bala ...
> -->
> because no space after the "<!--esi", the esi parser will keep these tags
> which should be removed.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
