[
https://issues.apache.org/jira/browse/TS-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870492#comment-13870492
]
Kit Chan commented on TS-2488:
------------------------------
Thanks. It works well.
I am wondering whether we can do better to keep test 42 of parser_test
unchanged. May be some special includes implementation may rely on that.
I think commenting out line 331 in the final version of lib/EsiParser.cc will
do the job.
I think it won't make a difference in other execution paths which it is shown
to keep all unit tests passed.
What do you think? Thanks.
> any of the space chars can follow the esi starting tags
> -------------------------------------------------------
>
> Key: TS-2488
> URL: https://issues.apache.org/jira/browse/TS-2488
> Project: Traffic Server
> Issue Type: Improvement
> Components: Plugins
> Reporter: Yu Qing
> Assignee: Kit Chan
> Attachments:
> 0001-TS-2488-any-space-char-can-follow-the-esi-starting-t.patch, 2488.txt,
> bugfix-for-TS-2488.patch
>
>
> only the space char ' ' can follow the esi starting tags such as
> "<esi:include", "<!--esi" now, we should allow any space char after these
> tags. the space chars include: ' ', '\t', '\r' and '\n'.
> for example, following common usage:
> <!--esi
> esi bala bala ...
> -->
> because no space after the "<!--esi", the esi parser will keep these tags
> which should be removed.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
