[
https://issues.apache.org/jira/browse/TS-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250264#comment-14250264
]
Eric Schwartz commented on TS-2157:
-----------------------------------
I have started work on this and wanted to bring up the following point/possible
ambiguity:
In HttpTransact.h we declare 4 sets of ConnectionAttributes. Right now each
stores only one addr. For each different set of ConnectionAttributes, it looks
like addr corresponds to slightly different things. For example, if we take a
connection path to go from the client, to ATS and then on to an origin,
client_info's addr is clearly a src_addr while server_info's seems to clearly
be a dst_addr. This means the additional field we are adding containing the
proxy's info could be either src_addr or dst_addr depending on which
ConnectionAttributes struct we are observing. This isn't a problem but is
ambiguous (might make additional logging TS-2152 less clear for example).
Is this possible ambiguity something we care about? I can totally implement
this as src_addr and dst_addr if that's the desired behavior, but would
something like proxy_addr and remote_addr make sense instead? So that we're
consistently storing the proxy's information in the same IpEndpoint in
ConnectionAttributes?
Thanks for any input anyone has.
> Replace "addr" with appropriate "src_addr" and "dst_addr" in
> ConnectionAttributes
> ---------------------------------------------------------------------------------
>
> Key: TS-2157
> URL: https://issues.apache.org/jira/browse/TS-2157
> Project: Traffic Server
> Issue Type: New Feature
> Components: Network
> Reporter: Leif Hedstrom
> Assignee: Eric Schwartz
> Fix For: 6.0.0
>
>
> This would more clearly let us encapsulate the two endpoint's (IpEndpoint)
> for each connection. In addition, we ought to be able to remove the "port"
> member from ConnectionAttributes as well, and its convoluted and overloaded
> semantics. The appropriate IpEndpoint (src_addr or dst_addr) would hold the
> port information as necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
