[ 
https://issues.apache.org/jira/browse/TS-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251248#comment-14251248
 ] 

Alan M. Carroll commented on TS-3186:
-------------------------------------

Looking at the diff, my main concern is about the use of 
{{REC_EstablishStaticConfigStringAlloc}}. Normally when this is used it is 
immediately {{strdup}}'d. Otherwise it can change asynchronously and the old 
value end up freed memory. In this case that could happen between the call to 
{{process_responder}} and the call to {{query_responder}} which may be 
problematic. On the other hand I don't think doing the {{strdup}} is a good 
idea either - that's a bit expensive on the main path. I'm not sure what a good 
approach is - fundamentally I think {{REC_EstablishStaticConfigStringAlloc}} is 
broken, as even with {{strdup}} there is still a window of vulnerability (note 
the non-string types can use atomics to avoid this issue). Perhaps in this case 
copying to a fixed size buffer would suffice.

> support ocsp queries through a proxy 
> -------------------------------------
>
>                 Key: TS-3186
>                 URL: https://issues.apache.org/jira/browse/TS-3186
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: SSL
>            Reporter: Atsutomo Kotani
>            Assignee: Alan M. Carroll
>             Fix For: 5.3.0
>
>         Attachments: ocsp_proxy.diff
>
>
> When ATS behind http proxy, it need ocsp queries through http proxy for ocsp 
> stapling. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to