[
https://issues.apache.org/jira/browse/TS-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395878#comment-14395878
]
Masakazu Kitajo commented on TS-3475:
-------------------------------------
I reviewed the patch, and found two points which may cause problems.
1. Initialization of Http2ConnectionSettings
I'm ok with using pre-tuned values by default, but only for server_settings. We
can't apply the configs to client_settings and must initialize it with the
default values what spec says. Because it is changed only by receiving a
SETTINGS frame sent by the peer. Initial values of client_settings should not
be configurable.
2. Use of the static member variables of Http2 class
They ought to be used only for initialization of server_configs, and we can't
simply replace the constant values (e.g. HTTP2_MAX_FRAME_SIZE) with them.
Strictly speaking, in http2_frame_header_is_valid, the size should be compared
to the value in server_settings.
Though I didn't check every use of the static members, some of them might have
to be read from client_settings; It can be updated in a transaction.
> Add configuration knobs for HTTP/2
> ----------------------------------
>
> Key: TS-3475
> URL: https://issues.apache.org/jira/browse/TS-3475
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP/2
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 6.0.0
>
> Attachments: TS-3475.diff
>
>
> We currently have the following SPDY configs, we should have at least the
> same ones for HTTP/2:
> {code}
> {RECT_CONFIG, "proxy.config.spdy.max_concurrent_streams_in", RECD_INT,
> "100", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
> {RECT_CONFIG, "proxy.config.spdy.no_activity_timeout_in", RECD_INT, "115",
> RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
> {RECT_CONFIG, "proxy.config.spdy.initial_window_size_in", RECD_INT,
> "1048576", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
> {RECT_CONFIG, "proxy.config.spdy.accept_no_activity_timeout", RECD_INT,
> "120", RECU_DYNAMIC, RR_NULL, RECC_STR, "^[0-9]+$", RECA_NULL}
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
