[ 
https://issues.apache.org/jira/browse/TS-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518174#comment-14518174
 ] 

Alan M. Carroll commented on TS-1015:
-------------------------------------

Yes. We had a long discussion about this on IRC earlier in the week and that 
was the concensus. I strongly support option 2. Each event would be marked with 
the enum value name, a descriptive string, and an internal flag. The internal 
flag would indicate the enum would go only in events.h and not apievents.h. 
Note the generator would have to account for this - it is *absolutely* required 
that enum values between the two definitions are identical.

> TSEvent is widely declared as int
> ---------------------------------
>
>                 Key: TS-1015
>                 URL: https://issues.apache.org/jira/browse/TS-1015
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Cleanup
>            Reporter: Nick Kew
>            Assignee: Meera Mosale Nataraja
>            Priority: Minor
>              Labels: api-change, newbie
>             Fix For: 6.0.0
>
>         Attachments: TS-1015-2.diff, TS-1015.diff
>
>
> TSEvent is an enum, defined in ts.h.  But in much of the code, TSEvent is 
> declared as type int.  This makes it harder to follow/debug using tools like 
> *trace or gdb.
> This may usefully be fixed as and when people encounter instances of it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to