[
https://issues.apache.org/jira/browse/TS-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597885#comment-14597885
]
ASF GitHub Bot commented on TS-2150:
------------------------------------
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/229#discussion_r33060322
--- Diff: proxy/http/HttpSM.cc ---
@@ -6662,48 +6668,61 @@ HttpSM::update_stats()
}
char client_ip[INET6_ADDRSTRLEN];
ats_ip_ntop(&t_state.client_info.addr, client_ip, sizeof(client_ip));
- Error("[%" PRId64 "] Slow Request: "
- "client_ip: %s:%u "
- "url: %s "
- "status: %d "
- "unique id: %s "
- "redirection_tries: %d "
- "bytes: %" PRId64 " "
- "fd: %d "
- "client state: %d "
- "server state: %d "
- "ua_begin: %.3f "
- "ua_first_read: %.3f "
- "ua_read_header_done: %.3f "
- "cache_open_read_begin: %.3f "
- "cache_open_read_end: %.3f "
- "dns_lookup_begin: %.3f "
- "dns_lookup_end: %.3f "
- "server_connect: %.3f "
- "server_first_read: %.3f "
- "server_read_header_done: %.3f "
- "server_close: %.3f "
- "ua_close: %.3f "
- "sm_finish: %.3f "
- "plugin_active: %.3f "
- "plugin_total: %.3f",
- sm_id, client_ip,
ats_ip_port_host_order(&t_state.client_info.addr), url_string, status,
unique_id_string,
- redirection_tries, client_response_body_bytes, fd,
t_state.client_info.state, t_state.server_info.state,
- milestone_difference(milestones.sm_start, milestones.ua_begin),
- milestone_difference(milestones.sm_start,
milestones.ua_first_read),
- milestone_difference(milestones.sm_start,
milestones.ua_read_header_done),
- milestone_difference(milestones.sm_start,
milestones.cache_open_read_begin),
- milestone_difference(milestones.sm_start,
milestones.cache_open_read_end),
- milestone_difference(milestones.sm_start,
milestones.dns_lookup_begin),
- milestone_difference(milestones.sm_start,
milestones.dns_lookup_end),
- milestone_difference(milestones.sm_start,
milestones.server_connect),
- milestone_difference(milestones.sm_start,
milestones.server_first_read),
- milestone_difference(milestones.sm_start,
milestones.server_read_header_done),
- milestone_difference(milestones.sm_start,
milestones.server_close),
- milestone_difference(milestones.sm_start, milestones.ua_close),
- milestone_difference(milestones.sm_start, milestones.sm_finish),
- milestone_difference(milestones.sm_start,
milestones.plugin_active),
- milestone_difference(milestones.sm_start,
milestones.plugin_total));
+ Error(
+ "[%" PRId64 "] Slow Request: "
+ "client_ip: %s:%u "
+ "url: %s "
+ "status: %d "
+ "unique id: %s "
+ "redirection_tries: %d "
+ "bytes: %" PRId64 " "
+ "fd: %d "
+ "client state: %d "
+ "server state: %d "
+ "ua_begin: %.3f "
+ "ua_first_read: %.3f "
+ "ua_read_header_done: %.3f "
+ "cache_open_read_begin: %.3f "
+ "cache_open_read_end: %.3f "
+ "dns_lookup_begin: %.3f "
+ "dns_lookup_end: %.3f "
+ "server_connect: %.3f "
+ "server_first_read: %.3f "
+ "server_read_header_done: %.3f "
+ "server_close: %.3f "
+ "ua_close: %.3f "
+ "sm_finish: %.3f "
+ "plugin_active: %.3f "
+ "plugin_total: %.3f",
+ sm_id, client_ip, ats_ip_port_host_order(&t_state.client_info.addr),
url_string, status, unique_id_string, redirection_tries,
+ client_response_body_bytes, fd, t_state.client_info.state,
t_state.server_info.state,
+
milestone_difference(milestones.ms_get(TransactionMilestones::SM_START),
milestones.ms_get(TransactionMilestones::UA_BEGIN)),
--- End diff --
Is this done enough to justify `TransactionMilestones::different(enum,
enum)` ?
> Add Milestone log tags
> ----------------------
>
> Key: TS-2150
> URL: https://issues.apache.org/jira/browse/TS-2150
> Project: Traffic Server
> Issue Type: New Feature
> Components: Logging
> Reporter: Leif Hedstrom
> Assignee: John Rushford
> Fix For: sometime
>
>
> We have a notion of milestones in the core, and plugin APIs
> (TSHttpTxnMilestoneGet() ). It'd be useful to expose these milestone timers
> as a log tag, something like:
> {code}
> %<{UA_BEGIN}mtms>
> {code}
> mtms is just an example / suggestion, "MilestoneTimeMilliSecond", we can make
> it whatever we like.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
