[
https://issues.apache.org/jira/browse/TS-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597890#comment-14597890
]
ASF GitHub Bot commented on TS-2150:
------------------------------------
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/229#discussion_r33060489
--- Diff: proxy/http/HttpTransact.cc ---
@@ -8856,75 +8856,100 @@ HttpTransact::update_size_and_time_stats(State *s,
ink_hrtime total_time, ink_hr
// update milestones stats
if (http_ua_begin_time_stat) {
- HTTP_SUM_TRANS_STAT(http_ua_begin_time_stat,
milestone_difference_msec(milestones.sm_start, milestones.ua_begin))
+ HTTP_SUM_TRANS_STAT(http_ua_begin_time_stat,
milestone_difference_msec(milestones.ms_get(TransactionMilestones::SM_START),
+
milestones.ms_get(TransactionMilestones::UA_BEGIN)))
--- End diff --
Here, at least, `milestone_difference_msec()` should take the enum values
and do the `ms_get` internally. That would look a lot cleaner.
> Add Milestone log tags
> ----------------------
>
> Key: TS-2150
> URL: https://issues.apache.org/jira/browse/TS-2150
> Project: Traffic Server
> Issue Type: New Feature
> Components: Logging
> Reporter: Leif Hedstrom
> Assignee: John Rushford
> Fix For: sometime
>
>
> We have a notion of milestones in the core, and plugin APIs
> (TSHttpTxnMilestoneGet() ). It'd be useful to expose these milestone timers
> as a log tag, something like:
> {code}
> %<{UA_BEGIN}mtms>
> {code}
> mtms is just an example / suggestion, "MilestoneTimeMilliSecond", we can make
> it whatever we like.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
