[
https://issues.apache.org/jira/browse/TS-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14631751#comment-14631751
]
Alan M. Carroll commented on TS-3774:
-------------------------------------
I will get to this as soon as possible.
I did a quick look and it occurs to be that we might want to have a wrapper
class for the HostDBInfo that supports Ptr<> and put that in the table. Then
when you copy over, you assign the Ptr<> and everything gets cleaned up
correctly.
I don't think there's a race condition between the HttpSM and the instance
because the HttpSM makes a copy (because those entries can disappear already
from the HttpSM point of view).
> Bug in HostDB hosts file implementation
> ---------------------------------------
>
> Key: TS-3774
> URL: https://issues.apache.org/jira/browse/TS-3774
> Project: Traffic Server
> Issue Type: Bug
> Components: HostDB
> Reporter: Brian Geffon
> Assignee: Alan M. Carroll
> Attachments: ts-3774.patch
>
>
> There is a bug in the current implementation of hostdb's use of hostsfiles.
> Because it uses a static local variable the storage is shared and ultimately
> will lead to race conditions if the hosts file is reloaded.
> {code}
> if (find_result != current_host_file_map->hosts_file_map.end()) {
> // TODO: Something to make this not local :/
> static HostDBInfo r;
> r.round_robin = false;
> r.round_robin_elt = false;
> r.reverse_dns = false;
> r.is_srv = false;
> ats_ip_set(r.ip(), (*find_result).second);
> return &r;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
