[ 
https://issues.apache.org/jira/browse/TS-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639593#comment-14639593
 ] 

ASF subversion and git services commented on TS-3774:
-----------------------------------------------------

Commit 5ae63a109255adccadddf0e726f20d657b2ac0c0 in trafficserver's branch 
refs/heads/master from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=5ae63a1 ]

TS-3774 clang-format


> Bug in HostDB hosts file implementation
> ---------------------------------------
>
>                 Key: TS-3774
>                 URL: https://issues.apache.org/jira/browse/TS-3774
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HostDB
>            Reporter: Brian Geffon
>            Assignee: Alan M. Carroll
>             Fix For: 6.1.0
>
>         Attachments: ts-3774.patch
>
>
> There is a bug in the current implementation of hostdb's use of hostsfiles. 
> Because it uses a static local variable the storage is shared and ultimately 
> will lead to race conditions if the hosts file is reloaded.
> {code}
> if (find_result != current_host_file_map->hosts_file_map.end()) {
>     // TODO: Something to make this not local :/
>     static HostDBInfo r;
>     r.round_robin = false;
>     r.round_robin_elt = false;
>     r.reverse_dns = false;
>     r.is_srv = false;
>     ats_ip_set(r.ip(), (*find_result).second);
>     return &r;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to