[
https://issues.apache.org/jira/browse/TS-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14961825#comment-14961825
]
Masakazu Kitajo commented on TS-3967:
-------------------------------------
I reviewed the patch and ran some test.
First, the patch needs at least two NULL checks, one in rcv_headers_frame() and
one in send_rst_stream_frame().
We have to check the return value after calling find_stream().
Second, a stream state is set to close indeed, however, the stream won't be
deleted until the connection has been closed. I assume this is expected and is
left in stream_list to achieve the behavior which I quoted on TS-3958.
It has to be done with care because some logic depend on return value of
find_stream().
Third, it seems the patch contains (partial?) support for trailing headers
(TS-3812). This may lead unexpected behavior, so it would be better to separate
it if it's possible.
> Set stream state to close after a RST_STEAM has been sent
> ---------------------------------------------------------
>
> Key: TS-3967
> URL: https://issues.apache.org/jira/browse/TS-3967
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP/2
> Reporter: Bryan Call
> Assignee: Bryan Call
> Fix For: 6.1.0
>
> Attachments: ts-3967.diff
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
