[ 
https://issues.apache.org/jira/browse/TS-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965325#comment-14965325
 ] 

Masakazu Kitajo commented on TS-3967:
-------------------------------------

Ok, I have no strong objection to add trailing header support, but I feel 
something is wrong around state handling. I'll file another ticket if I find 
any.

I found another coredump scenario. We should check the state when receiving 
window update for a specific stream too.

{noformat}
[Oct 21 00:58:49.516] Server {0xb0590000} DEBUG: (http2_cs) [0] Received 
WINDOW_UPDATE frame.
[Oct 21 00:58:49.516] Server {0xb0590000} DEBUG: (http2_cs) [0] Send DATA frame
Process 50096 stopped
* thread #2: tid = 0x3b9c14, 0x0000000100022ddc 
traffic_server`FetchSM::ext_get_user_data(this=0x0000000000000000) + 12 at 
FetchSM.cc:689, name = '[ET_SSL 0]', stop reason = EXC_BAD_ACCESS (code=1, 
address=0x1d8)
    frame #0: 0x0000000100022ddc 
traffic_server`FetchSM::ext_get_user_data(this=0x0000000000000000) + 12 at 
FetchSM.cc:689
   686  void *
   687  FetchSM::ext_get_user_data()
   688  {
-> 689    return user_data;
   690  }
   691
   692  TSMBuffer
(lldb) bt
* thread #2: tid = 0x3b9c14, 0x0000000100022ddc 
traffic_server`FetchSM::ext_get_user_data(this=0x0000000000000000) + 12 at 
FetchSM.cc:689, name = '[ET_SSL 0]', stop reason = EXC_BAD_ACCESS (code=1, 
address=0x1d8)
  * frame #0: 0x0000000100022ddc 
traffic_server`FetchSM::ext_get_user_data(this=0x0000000000000000) + 12 at 
FetchSM.cc:689
    frame #1: 0x00000001001ae155 
traffic_server`Http2ConnectionState::send_data_frame(this=0x0000000000a32118, 
fetch_sm=0x0000000000000000) + 437 at Http2ConnectionState.cc:904
    frame #2: 0x00000001001b18a9 
traffic_server`rcv_window_update_frame(cs=0x0000000000a31eb0, 
cstate=0x0000000000a32118, frame=0x00000000b058f460) + 969 at 
Http2ConnectionState.cc:584
{noformat}



> Set stream state to close after a RST_STEAM has been sent
> ---------------------------------------------------------
>
>                 Key: TS-3967
>                 URL: https://issues.apache.org/jira/browse/TS-3967
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: HTTP/2
>            Reporter: Bryan Call
>            Assignee: Bryan Call
>             Fix For: 6.1.0
>
>         Attachments: ts-3967.diff
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to