[
https://issues.apache.org/jira/browse/TS-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018824#comment-15018824
]
ASF GitHub Bot commented on TS-4034:
------------------------------------
GitHub user bgaff opened a pull request:
https://github.com/apache/trafficserver/pull/345
TS-4034: Minor atscppapi cleanup
A few things should be cleaned up in atscppapi.
- CaseInsensitiveStringComparitor isn't used internally but it is exposed
in a public API, so because we can't remove it we should change it to use
strcasecmp() under the covers.
- In several places we do:
somestr = std::string(ptr, len);
We should do:
somestr.assign(ptr,len);
- We use c style includes in a few places when we should use the c++
equivalents.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bgaff/trafficserver ts-4034
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/345.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #345
----
commit def017b4b19619497dcc378595494b97cbc9eb27
Author: Brian Geffon <[email protected]>
Date: 2015-11-19T17:57:27Z
TS-4034: Minor atscppapi cleanup
----
> Minor atscppapi cleanup
> -----------------------
>
> Key: TS-4034
> URL: https://issues.apache.org/jira/browse/TS-4034
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: Brian Geffon
> Assignee: Brian Geffon
> Fix For: 6.1.0
>
>
> A few things should be cleaned up in atscppapi.
> - CaseInsensitiveStringComparitor isn't used internally but it is exposed in
> a public API, so because we can't remove it we should change it to use
> strcasecmp() under the covers.
> - In several places we do:
> somestr = std::string(ptr, len);
> We should do:
> somestr.assign(ptr,len);
> - We use c style includes in a few places when we should use the c++
> equivalents.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
