[ 
https://issues.apache.org/jira/browse/TS-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018831#comment-15018831
 ] 

ASF GitHub Bot commented on TS-4034:
------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/trafficserver/pull/345


> Minor atscppapi cleanup
> -----------------------
>
>                 Key: TS-4034
>                 URL: https://issues.apache.org/jira/browse/TS-4034
>             Project: Traffic Server
>          Issue Type: Improvement
>            Reporter: Brian Geffon
>            Assignee: Brian Geffon
>             Fix For: 6.1.0
>
>
> A few things should be cleaned up in atscppapi.
>  - CaseInsensitiveStringComparitor isn't used internally but it is exposed in 
> a public API, so because we can't remove it we should change it to use 
> strcasecmp() under the covers.
>  - In several places we do:
>     somestr = std::string(ptr, len);
>   We should do:
>     somestr.assign(ptr,len);
>  - We use c style includes in a few places when we should use the c++ 
> equivalents.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to