[
https://issues.apache.org/jira/browse/TS-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041835#comment-15041835
]
ASF GitHub Bot commented on TS-4054:
------------------------------------
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/363#issuecomment-162032775
`setup_diagslog` is only ever called within the `Diags.cc` constructor. If
you look at the original change in commit b29149c2, you'll see that I actually
made a mistake in transcribing over the if-statement to an assert.
> Incorrect ink_assert behavior in Diags.cc
> -----------------------------------------
>
> Key: TS-4054
> URL: https://issues.apache.org/jira/browse/TS-4054
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
> Reporter: Daniel Xu
> Fix For: 6.1.0
>
>
> In `lib/ts/Diags.cc:setup_diagslog()`, the statement `ink_assert(diags_log ==
> NULL)` is incorrect. It should instead be: `if (blf == NULL) return`
> We should not use an assert here either because when the function is passed a
> NULL `blf`, it means that some test doesn't want to use the diags.log log
> file and we should just not set up diagslog.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
