[
https://issues.apache.org/jira/browse/TS-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041843#comment-15041843
]
ASF GitHub Bot commented on TS-4054:
------------------------------------
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/363#issuecomment-162033316
Yes. Looking at the code it seems the better choice would be to keep the
assert and move it after the `NULL` check on `blf`. I would be tempted to,
rather than return there, reverse the check ( `blf != NULL` ) and enclose the
rest of the function in that clause, including the assert.
> Incorrect ink_assert behavior in Diags.cc
> -----------------------------------------
>
> Key: TS-4054
> URL: https://issues.apache.org/jira/browse/TS-4054
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
> Reporter: Daniel Xu
> Fix For: 6.1.0
>
>
> In `lib/ts/Diags.cc:setup_diagslog()`, the statement `ink_assert(diags_log ==
> NULL)` is incorrect. It should instead be: `if (blf == NULL) return`
> We should not use an assert here either because when the function is passed a
> NULL `blf`, it means that some test doesn't want to use the diags.log log
> file and we should just not set up diagslog.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
