[
https://issues.apache.org/jira/browse/TS-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044235#comment-15044235
]
ASF GitHub Bot commented on TS-4018:
------------------------------------
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/362#discussion_r46780362
--- Diff: proxy/http2/HPACK.cc ---
@@ -332,18 +332,41 @@ int64_t
encode_string(uint8_t *buf_start, const uint8_t *buf_end, const char
*value, size_t value_len)
{
uint8_t *p = buf_start;
+ bool use_huffman = true;
--- End diff --
I left the flag for further use. There are some cases that plain text is
shorter than huffman encoded data, and the codes for both cases would be used
when we found a smart way to switch the encoding.
> Use the huffman encode in HPACK
> -------------------------------
>
> Key: TS-4018
> URL: https://issues.apache.org/jira/browse/TS-4018
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP/2
> Reporter: Masakazu Kitajo
> Fix For: 6.1.0
>
>
> A huffman encoder is exist in the HPACK implementation (TS-3852) but it
> doesn't seem to be used. It isn't included in TS-3478 also.
> We could use the huffman encoder.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
