[
https://issues.apache.org/jira/browse/TS-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044250#comment-15044250
]
ASF GitHub Bot commented on TS-4018:
------------------------------------
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/362#discussion_r46780770
--- Diff: proxy/http2/HPACK.cc ---
@@ -332,18 +332,41 @@ int64_t
encode_string(uint8_t *buf_start, const uint8_t *buf_end, const char
*value, size_t value_len)
{
uint8_t *p = buf_start;
+ bool use_huffman = true;
--- End diff --
According to [Compression
Ratio](https://github.com/http2jp/hpack-test-case/wiki/Compression-Ratio) in
[hpack-test-case](https://github.com/http2jp/hpack-test-case), the best
compression rate is `0.31` but compression rate of naive-huffman imprementation
(I guess this is similar to this PR) is `0.85`. So we have to back to here and
implement smart algorithm.
> Use the huffman encode in HPACK
> -------------------------------
>
> Key: TS-4018
> URL: https://issues.apache.org/jira/browse/TS-4018
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP/2
> Reporter: Masakazu Kitajo
> Fix For: 6.1.0
>
>
> A huffman encoder is exist in the HPACK implementation (TS-3852) but it
> doesn't seem to be used. It isn't included in TS-3478 also.
> We could use the huffman encoder.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
