[
https://issues.apache.org/jira/browse/TS-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056467#comment-15056467
]
ASF GitHub Bot commented on TS-4070:
------------------------------------
GitHub user cschombu opened a pull request:
https://github.com/apache/trafficserver/pull/375
TS-4070 RemapProcessor Forward Mapping with Recv Port failing with TS…
…-2157 changes
During the rework of RemapProcessor.cc, RemapProcessor::setup_for_remap()
as part of the TS-2157 changeset, the port access API appears to have been
incorrectly modified to use the client_info.src_addr.host_order_port() API
[source port, host order] instead of the client_info.dst_addr.port()
[destination/receive port, network order] API. This caused port based
remapping based on the receive port to fail with ATS 6.0.0.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cschombu/trafficserver TS-4070
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/375.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #375
----
commit 83851dc1ee5f147024cca3f5129a1d266f273ecd
Author: Craig Schomburg <[email protected]>
Date: 2015-12-14T18:53:19Z
TS-4070 RemapProcessor Forward Mapping with Recv Port failing with TS-2157
changes
During the rework of RemapProcessor.cc, RemapProcessor::setup_for_remap()
as part of the TS-2157 changeset, the port access API appears to have been
incorrectly modified to use the client_info.src_addr.host_order_port() API
[source port, host order] instead of the client_info.dst_addr.port()
[destination/receive port, network order] API. This caused port based
remapping based on the receive port to fail with ATS 6.0.0.
----
> RemapProcessor Forward Mapping with Recv Port failing with TS-2157 changes
> --------------------------------------------------------------------------
>
> Key: TS-4070
> URL: https://issues.apache.org/jira/browse/TS-4070
> Project: Traffic Server
> Issue Type: Bug
> Components: Network
> Reporter: Craig Schomburg
> Priority: Critical
> Labels: regression
> Fix For: 6.1.0
>
> Attachments: TS-4070.patch
>
>
> During the rework of RemapProcessor.cc, RemapProcessor::setup_for_remap() as
> part of the TS-2157 changeset, the port access API appears to have been
> incorrectly modified to use the client_info.src_addr.host_order_port() API
> [source port, host order] instead of the client_info.dst_addr.port()
> [destination/receive port, network
> order] API. This caused port based remapping based on the receive port to
> fail with ATS 6.0.0.
> Functionality was previously working with ATS 4.0.1.
> See attached patch that was used to restore the ATS 4.0.1 functionality.
> Looking for confirmation that this fix/patch was correct.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
