[
https://issues.apache.org/jira/browse/TS-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061001#comment-15061001
]
ASF GitHub Bot commented on TS-4070:
------------------------------------
Github user ericcarlschwartz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/375#discussion_r47842310
--- Diff: proxy/http/remap/RemapProcessor.cc ---
@@ -88,7 +88,7 @@ RemapProcessor::setup_for_remap(HttpTransact::State *s)
if (rewrite_table->num_rules_forward_with_recv_port) {
Debug("url_rewrite", "[lookup] forward mappings with recv port found;
Using recv port %d", s->client_info.src_addr.port());
--- End diff --
Could you also update the debug message to use the same port you changed it
to?
> RemapProcessor Forward Mapping with Recv Port failing with TS-2157 changes
> --------------------------------------------------------------------------
>
> Key: TS-4070
> URL: https://issues.apache.org/jira/browse/TS-4070
> Project: Traffic Server
> Issue Type: Bug
> Components: Network
> Reporter: Craig Schomburg
> Assignee: Eric Schwartz
> Priority: Critical
> Labels: regression
> Fix For: 6.1.0
>
> Attachments: TS-4070.patch
>
>
> During the rework of RemapProcessor.cc, RemapProcessor::setup_for_remap() as
> part of the TS-2157 changeset, the port access API appears to have been
> incorrectly modified to use the client_info.src_addr.host_order_port() API
> [source port, host order] instead of the client_info.dst_addr.port()
> [destination/receive port, network
> order] API. This caused port based remapping based on the receive port to
> fail with ATS 6.0.0.
> Functionality was previously working with ATS 4.0.1.
> See attached patch that was used to restore the ATS 4.0.1 functionality.
> Looking for confirmation that this fix/patch was correct.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
