[
https://issues.apache.org/jira/browse/TS-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061012#comment-15061012
]
ASF GitHub Bot commented on TS-4056:
------------------------------------
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/381
TS-4056: Remove cached netVC from NetAccept
This is an updated, rebased version of PR 366[1].
[1] https://github.com/apache/trafficserver/pull/366
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver ts-4056
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/381.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #381
----
commit 416b5673ffe18119569d792729bbb293b459a4be
Author: Oknet <[email protected]>
Date: 2015-12-07T14:13:42Z
remove alloc_cache from class NetAccept definition
commit 9c5d82244dce937163527939d689425a0812b359
Author: Oknet <[email protected]>
Date: 2015-12-07T14:42:27Z
remove alloc_cache from net_accept()
remove alloc_cache from net_accept() to avoid mem leak on ~NetAccept()
commit a6caf9369ab767e382f94428a8811c03930b074f
Author: Oknet <[email protected]>
Date: 2015-12-07T14:47:11Z
fix vc->con to con
----
> MemLeak: ～NetAccept() do not free alloc_cache(vc)
> -------------------------------------------------
>
> Key: TS-4056
> URL: https://issues.apache.org/jira/browse/TS-4056
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Affects Versions: 6.1.0
> Reporter: Oknet Xu
> Assignee: Bryan Call
> Labels: review
> Fix For: 6.2.0
>
>
> NetAccpet::alloc_cache is a void pointor is used in net_accept().
> the alloc_cache does not release after NetAccept canceled.
> I'm looking for all code, believe the "alloc_cache" is a bad idea here.
> I create a pull request on github:
> https://github.com/apache/trafficserver/pull/366
> also add a condition check for vc==NULL after allocate_vc()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
