[
https://issues.apache.org/jira/browse/TS-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069760#comment-15069760
]
ASF GitHub Bot commented on TS-4056:
------------------------------------
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/381#issuecomment-166927897
The change looks good. I don't see the benefits of the original
"pre-allocation" compared to the increased code complexity.
> MemLeak: ～NetAccept() do not free alloc_cache(vc)
> -------------------------------------------------
>
> Key: TS-4056
> URL: https://issues.apache.org/jira/browse/TS-4056
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Affects Versions: 6.1.0
> Reporter: Oknet Xu
> Assignee: Bryan Call
> Labels: review
> Fix For: 6.2.0
>
>
> NetAccpet::alloc_cache is a void pointor is used in net_accept().
> the alloc_cache does not release after NetAccept canceled.
> I'm looking for all code, believe the "alloc_cache" is a bad idea here.
> I create a pull request on github:
> https://github.com/apache/trafficserver/pull/366
> also add a condition check for vc==NULL after allocate_vc()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
